This repository was archived by the owner on Jan 13, 2025. It is now read-only.
feat(ripple): Reduce press opacity by 25% #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 621 screenshot tests passed for commit c4aebf0 vs. |
abhiomkar
approved these changes
Feb 5, 2019
nshahan
pushed a commit
to angulardart/angular_components
that referenced
this pull request
Apr 1, 2019
material-components/material-components-web#4350 PiperOrigin-RevId: 235591237
nshahan
pushed a commit
to angulardart/angular_components
that referenced
this pull request
Apr 15, 2019
material-components/material-components-web#4350 PiperOrigin-RevId: 235591237
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being made after review by designers based on user feedback indicating that 16% press opacity in on-surface situations seems too pronounced. Designers also tested baseline on-primary for the reduction from 32% to 24% in that case.